Fix atlasian and JIRA cloud login#233
Conversation
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
|
Warning Review limit reached
More reviews will be available in 40 minutes and 58 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughVersion 0.10.4 is bumped across Dockerfile environment variables, workflow Quay tags, and Makefile build targets. The Makefile reorganizes image builds into separate targets. The eol-checker refactors Jira authentication to use token-based credentials and adds HTTP error handling. Checker initialization removes direct debug flag assignment and sets up email formatting state. ChangesBuild Infrastructure and eol-checker Refactoring
🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 62.42% 62.16% -0.26%
==========================================
Files 13 13
Lines 1344 1348 +4
==========================================
- Hits 839 838 -1
- Misses 505 510 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@eol-checker/eol_checker/jira.py`:
- Line 29: The debug log in jira.py prints the sensitive variable jira_token;
remove that token logging and replace it with a non-sensitive message (e.g., log
that a token was provided or log only its length/hex-masked form) so credentials
are never written to logs. Locate the logger.debug call that references
jira_token and either delete it or change it to a redacted/metadata-only message
(no raw token value) in the function/module that initializes JIRA
authentication.
- Around line 50-55: The code calls self.jira.issue(...) without checking that
the jira client exists, causing an AttributeError when JIRA_TOKEN/JIRA_USERNAME
are missing; update the try block in the method that uses self.jira (where
jira_deprecation_ticket is referenced) to first guard against None by checking
if self.jira is truthy and if not, log a clear message and skip calling
self.jira.issue; keep the existing HTTPError exception handling for real HTTP
failures and ensure self.jira_details is only assigned when issue is retrieved.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 30f6e69d-c8bd-4d37-994e-387521324a5d
📒 Files selected for processing (6)
.github/workflows/build-and-push.ymlDockerfile.daily-testsDockerfile.eol-checkerMakefileeol-checker/eol_checker/checker.pyeol-checker/eol_checker/jira.py
💤 Files with no reviewable changes (1)
- eol-checker/eol_checker/checker.py
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
1 participant
Summary by CodeRabbit
Build Updates
Improvements